[Webkit-unassigned] [Bug 204503] [GTK][WPE] RemoteInspector: use sockets instead of DBus

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 06:06:03 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=204503

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 384141
  --> https://bugs.webkit.org/attachment.cgi?id=384141
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384141&action=review

> Source/WTF/wtf/glib/SocketConnection.cpp:125
> +        memmove(m_readBuffer.data(), m_readBuffer.data() + messageSize, m_readBuffer.size() - messageSize);

This could be std::memmove().

> Source/WTF/wtf/glib/SocketConnection.cpp:175
> +        memmove(m_writeBuffer.data(), m_writeBuffer.data() + bytesWritten, m_writeBuffer.size() - bytesWritten);

And this too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191122/ca344e8c/attachment.htm>


More information about the webkit-unassigned mailing list