[Webkit-unassigned] [Bug 204484] Impossible to debug webkitpy tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 18:28:12 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=204484

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
I'm writing new tests and trying to use 'print' or _log.info() in them, but all that output is dropped.

Printer.configure() explicitly filters this output:

        # Filter out most webkitpy messages.
        #
        # Messages can be selectively re-enabled for this script by updating
        # this method accordingly.
        def filter_records(record):
            """Filter out autoinstall and non-third-party webkitpy messages."""
            # FIXME: Figure out a way not to use strings here, for example by
            #        using syntax like webkitpy.test.__name__.  We want to be
            #        sure not to import any non-Python 2.4 code, though, until
            #        after the version-checking code has executed.
            if (record.name.startswith("webkitpy.common.system.autoinstall") or
                record.name.startswith("webkitpy.test")):
                return True
            if record.name.startswith("webkitpy"):
                return False
            return True

        testing_filter = logging.Filter()
        testing_filter.filter = filter_records

        # Display a message so developers are not mystified as to why
        # logging does not work in the unit tests.
        _log.info("Suppressing most webkitpy logging while running unit tests.")
        handler.addFilter(testing_filter)


I want --verbose (or another flag) to remove this filtering.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191122/13502ab4/attachment.htm>


More information about the webkit-unassigned mailing list