[Webkit-unassigned] [Bug 204479] New: Fix broken String.prototype.replace() and replaceAll().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204479

            Bug ID: 204479
           Summary: Fix broken String.prototype.replace() and
                    replaceAll().
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

String.prototype.replace() regressed due to r252683: <https://trac.webkit.org/r252683> for webkit.org/b/202471.  The patch failed to handle InternalFunctions.

This patch also fixed a spec compliance bug for String.prototype.replace() i.e. the replaceValue needs to be evaluated before we check if there's a match in the source string.  See 21.1.3.14-9 at https://www.ecma-international.org/ecma-262/6.0/#sec-string.prototype.replace.

For String.prototype.replaceAll(), make sure it "behaves just like String.prototype.replace if searchValue is a global regular expression".  See https://github.com/tc39/proposal-string-replaceall.

<rdar://problem/57354854>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191122/22371e3b/attachment.htm>