[Webkit-unassigned] [Bug 204407] Move some alignment tests to the wpt folder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204407

Manuel Rego Casasnovas <rego at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #383957|review?                     |review-
              Flags|                            |

--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 383957
  --> https://bugs.webkit.org/attachment.cgi?id=383957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383957&action=review

Thanks for working on this, but you need to do some changes on this patch.

> LayoutTests/ChangeLog:8
> +        Replacing some tests from fast/css-grid/alignment to the web platform test folder

The tests are already upstream in WPT, so this is basically importing them and removing the duplicates in WebKit local tests.
It'd be nice if you explain that on the ChangeLog properly.

> LayoutTests/ChangeLog:10
> +        * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html: Removed.

This doesn't seem accurate.

ChangeLog is auto-generated, so it should include automatically all the tests you're removing.

> LayoutTests/ChangeLog:662
> +        <rdar://problem/56801615>

Your patch shouldn't include changes in other parts of the ChangeLog.
I guess your editor was removing trailing white-spaces or something like that and causing the changes here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191120/7f0e35e5/attachment.htm>