[Webkit-unassigned] [Bug 204332] Nullptr crash in Node::setTextContent via Document::setTitle if title element is removed before setTextContent call.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204332

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 383904
  --> https://bugs.webkit.org/attachment.cgi?id=383904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383904&action=review

> Source/WebCore/dom/Document.cpp:1601
> +        // insertBefore above may have ran scripts which removed m_titleElement

...may have run scripts... Also period at the end (we like comments to be full sentences).

> Source/WebCore/dom/Document.cpp:1612
> +        // appendChild above may have ran scripts which removed m_titleElement

Same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191120/b16074d9/attachment.htm>