[Webkit-unassigned] [Bug 204306] New: Web Inspector: DOM.highlightSelector should work for "div, div::before"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204306

            Bug ID: 204306
           Summary: Web Inspector: DOM.highlightSelector should work for
                    "div, div::before"
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com
        Depends on: 146161

(In reply to Antti Koivisto from comment https://webkit.org/b/146161#c14)
> Comment on attachment 383496 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383496&action=review
> 
> > Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1286
> > +            if (selectorChecker.match(*selector, descendantElement, context, ignoredSpecificity)) {
> > +                nodes.append(descendantElement);
> > +                break;
> > +            }
> 
> Shouldn't this continue instead of break? If you have selector like '.foo, .foo::before' I think the current code will only highlight .foo.
> 
> > Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1305
> > +                    break;
> 
> This too.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=146161
[Bug 146161] Web Inspector: DOM.highlightSelector should work for "a:visited"
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191118/41ad4bf1/attachment.htm>