[Webkit-unassigned] [Bug 204230] New: [GTK] http/tests/xmlhttprequest/cross-origin-cookie-storage.html [since r249619] [Remove calls to WKContextGetWebsiteDataStore missed in r249614]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204230

            Bug ID: 204230
           Summary: [GTK]
                    http/tests/xmlhttprequest/cross-origin-cookie-storage.
                    html [since r249619] [Remove calls to
                    WKContextGetWebsiteDataStore missed in r249614]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: psaavedra at igalia.com
                CC: achristensen at apple.com, bugs-noreply at webkitgtk.org

Introduced by:


commit cdfb1cd5224630a87d2d14fd389bafc45747e1f9
Author: achristensen at apple.com <achristensen at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Sep 7 22:54:22 2019 +0000

    Remove calls to WKContextGetWebsiteDataStore missed in r249614
    https://bugs.webkit.org/show_bug.cgi?id=200050

    Source/WebKit:

    It turns out I didn't need to introduce another way of clearing all cookies between tests.
    I just needed to make the call to WKHTTPCookieStoreDeleteAllCookies use the right WebsiteDataStore.

    * NetworkProcess/NetworkProcess.cpp:
    (WebKit::NetworkProcess::clearCachedCredentials):
    * NetworkProcess/NetworkSession.h:
    (WebKit::NetworkSession::clearCredentials):
    (WebKit::NetworkSession::clearCookies): Deleted.
    * NetworkProcess/cocoa/NetworkSessionCocoa.h:
    * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
    (WebKit::NetworkSessionCocoa::clearCookies): Deleted.

    Tools:

    * WebKitTestRunner/TestController.cpp:
    (WTR::TestController::resetPreferencesToConsistentValues):
    (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
    * WebKitTestRunner/TestInvocation.cpp:
    (WTR::TestInvocation::invoke):



    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@249619 268f45cc-cd09-0410-ab3c-d52691b4dbfc


Diff:

--- /home/igalia/psaavedra/repos/webkit-gtk/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt
+++ /home/igalia/psaavedra/repos/webkit-gtk/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/cross-origin-cookie-storage-actual.txt
@@ -7,6 +7,6 @@
 PASS: No cookies set.
 Cross-origin XMLHttpRequest (sync), testing that cookies are set when sending credentials.
 PASS: Finished sync xhr.
-PASS: Cookie set.
+FAIL: no cookie set.
 DONE

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191115/f9190595/attachment-0001.htm>