[Webkit-unassigned] [Bug 180424] [Win] UIScriptController::zoomToScale not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180424

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #383026|review?                     |review+
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383026
  --> https://bugs.webkit.org/attachment.cgi?id=383026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383026&action=review

> Tools/DumpRenderTree/win/UIScriptControllerWin.cpp:69
> +    // FIXME: No API to get the page scale factor

I think at this point we probably don't want to fix this.

> Tools/WebKitTestRunner/win/UIScriptControllerWin.cpp:44
> +    callOnMainThread([this, protectedThis = makeRef(*this), callbackID ] {

I don't see why this is necessary.  Can't we just complete the task immediately?  We're never on a non-main thread, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191108/31227031/attachment.htm>