[Webkit-unassigned] [Bug 180408] WebDriver: implement proxy support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180408

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 383117
  --> https://bugs.webkit.org/attachment.cgi?id=383117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383117&action=review

>> Source/WebDriver/WebDriverService.cpp:367
>> +    }
> 
> This type of proxy doesn't seem to be handled.
> Maybe returning an error is more according to the spec than silently accepting it and ignoring it?

Yes, I thought about it, I'll add a way to ask platform is a particular proxy types is supported.

>> Source/WebDriver/WebDriverService.cpp:415
>> +        }
> 
> socksVersionValue seems to be ignored when constructing socksURL.
> It is true that webkit_network_proxy_settings_add_proxy_for_scheme() works with the three types of sock proxies if not a specific version is specified, but I think its better to be specific here is the user/application has requested a specific type of proxy.
> 
> This is my suggestion:
> * proxy.socksURL should start with:
>   - if socksVersionValue is invalid/missing or anything other than 4 or 5 -> socks:// 
>   - if socksVersionValue is 4 and socksURL is an IP Adresss -> socks4:// 
>   - if socksVersionValue is 4 and socksURL is a domain name -> socks4a:// 
>   - if socksVersionValue is 5 -> socks5://

I had no idea how to specify the socks version, I'll do what you suggest here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191108/c6e89e17/attachment.htm>