[Webkit-unassigned] [Bug 203992] New: Correct editing commands' InputEvent::inputType values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203992

            Bug ID: 203992
           Summary: Correct editing commands' InputEvent::inputType values
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcrha at redhat.com
                CC: wenson_hsieh at apple.com

Created attachment 383115

  --> https://bugs.webkit.org/attachment.cgi?id=383115&action=review

wk2-inputType.c

This is a follow up from bug #203944.

I took a set of expected Inputevent::inputType values, as specified here:
https://w3c.github.io/input-events/#interface-InputEvent-Attributes
and checked what WebKitGTK+ use. The attached program shows the result (its first line contains a command to build&run it). It's not an exhaustive list, but it shows several inconsistencies.

Below is a table of the outputs, where those with '*' are failures from the standard:

  Editing cmd             |  expected                    | received
  'insertText'            | 'insertText'                 | 'insertText'
  'InsertLineBreak'       | 'insertLineBreak'            | 'insertLineBreak'
  'InsertParagraph'       | 'insertParagraph'            | 'insertParagraph'
  'InsertOrderedList'     | 'insertOrderedList'          | 'insertOrderedList'
  'InsertUnorderedList'   | 'insertUnorderedList'        | 'insertUnorderedList'
* 'InsertHorizontalRule'  | 'insertHorizontalRule'       | 'insertText'
* 'InsertLink'            | 'insertLink'                 | '*timeout*'
  'Paste'                 | 'insertFromPaste'            | 'insertFromPaste'
  'PasteAsPlainText'      | 'insertFromPaste'            | 'insertFromPaste'
* 'PasteAsQuotation'      | 'insertFromPasteAsQuotation' | 'insertFromPaste'
  'bold'                  | 'formatBold'                 | 'formatBold'
  'Italic'                | 'formatItalic'               | 'formatItalic'
  'Underline'             | 'formatUnderline'            | 'formatUnderline'
- 'Strikethrough'         | 'formatStrikeThrough'        | 'formatUnderline' (fixed by bug #203944)
  'Superscript'           | 'formatSuperscript'          | 'formatSuperscript'
  'Subscript'             | 'formatSubscript'            | 'formatSubscript'
  'JustifyFull'           | 'formatJustifyFull'          | 'formatJustifyFull'
  'JustifyCenter'         | 'formatJustifyCenter'        | 'formatJustifyCenter'
  'JustifyRight'          | 'formatJustifyRight'         | 'formatJustifyRight'
  'JustifyLeft'           | 'formatJustifyLeft'          | 'formatJustifyLeft'
  'Indent'                | 'formatIndent'               | 'formatIndent'
  'Outdent'               | 'formatOutdent'              | 'formatOutdent'
  'MakeTextWritingDirectionLeftToRight' | 'formatSetInlineTextDirection' | 'formatSetInlineTextDirection'
  'MakeTextWritingDirectionRightToLeft' | 'formatSetInlineTextDirection' | 'formatSetInlineTextDirection'
* 'BackColor'             | 'formatBackColor'            | ''
  'ForeColor'             | 'formatFontColor'            | 'formatFontColor'
* 'FontName'              | 'formatFontName'             | ''
  'InsertHTML'            | 'insertText'                 | 'insertText'
* 'RemoveFormat'          | 'formatRemove'               | ''
  'Undo'                  | 'historyUndo'                | 'historyUndo'
  'Redo'                  | 'historyRedo'                | 'historyRedo'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191108/c27d8770/attachment.htm>