[Webkit-unassigned] [Bug 203944] 'Strikethrough' editing command reported as 'formatUnderline'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203944

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |wenson_hsieh at apple.com
          Component|WebKitGTK                   |HTML Editing
            Summary|[GTK] 'Strikethrough'       |'Strikethrough' editing
                   |editing command reported as |command reported as
                   |'formatUnderline'           |'formatUnderline'

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
This is not GTK specific.

static bool executeStrikethrough(Frame& frame, Event*, EditorCommandSource source, const String&)
{
    Ref<EditingStyle> style = EditingStyle::create();
    style->setStrikeThroughChange(textDecorationChangeForToggling(frame.editor(), CSSPropertyWebkitTextDecorationsInEffect, "line-through"_s));
    // FIXME: Needs a new EditAction!                                                                                                                                                         
    return applyCommandToFrame(frame, source, EditAction::Underline, WTFMove(style));
}

Regarding others identified as empty string is probably because they are not listed in:

https://w3c.github.io/input-events/#interface-InputEvent-Attributes

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191107/123cf362/attachment.htm>