[Webkit-unassigned] [Bug 203943] New: Remove unimplemented property error log in when getting a property value from a computed style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 21:59:38 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=203943

            Bug ID: 203943
           Summary: Remove unimplemented property error log in when
                    getting a property value from a computed style
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
        Depends on: 198680

In r251581, the list of computed CSS properties was changed to be autogenerated from 'CSSProperties.json'.  One issue that arose from this was that `-webkit-text-decorations-in-effect` was no longer part of the `CSSComputedStyleDeclaration`, which caused a number of editing tests to fail, as that property is used for holding internal state related to various editing commands (e.g. `document.execCommand`).  In order to get around this, `ComputedStyleExtractor::copyProperties()` was modified to instead copy _all_ CSS properties, regardless of whether they're part of the set of computed CSS properties.  Unfortunately, this had a side effect of triggering a longstanding `LOG_ERROR` (added in r6178) when attempting to retrieve the value of certain CSS properties (e.g. `-internal-text-autosizing-status`).  Since this path can be triggered by any arbitrary JavaScript (e.g. `window.getComputedStyle(document.body).getPropertyCSSValue("-internal-text-autosizing-status")`), it doesn't add much benefit to have this log, especially since the code itself is already annotated with comments/FIXMEs for CSS properties that don't have a computed value.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=198680
[Bug 198680] Automate generation of computedProperties
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191107/dc9b115e/attachment.htm>


More information about the webkit-unassigned mailing list