[Webkit-unassigned] [Bug 203818] Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203818

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #382773|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 382773
  --> https://bugs.webkit.org/attachment.cgi?id=382773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382773&action=review

Nice! I put r- because I found a bug.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:1081
> +    ASSERT(enumerationMode.includeJSObjectProperties());

"getOwnPropertyNames " is a part of public interface of JSObject. So, we allow clients to call this "getOwnPropertyNames" function directly. Like,

object->methodTable(vm)->getOwnPropertyNames(object, ...);

So, this ASSERT is not correct. Can you fix it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191104/170aaedc/attachment-0001.htm>