[Webkit-unassigned] [Bug 203788] Don't show the broken image icon for missing CSS images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203788

--- Comment #1 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #0)
> We currently render the broken image icon for missing CSS images
> (backgrounds, border-image etc) but I don't think we should. I think we
> should only show it for content images.

How can this happen? Can you include a test case?

In RenderBoxModelObject::paintFillLayerExtended() we check:

bool shouldPaintBackgroundImage = bgImage && bgImage->canRender(this, style().effectiveZoom());

If the image is missing, bgImage will be null. And if an error happens while loading or decoding the image, bgImage->canRender() will return false. In both cases drawing the background image step will be skipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191104/fa8b33fe/attachment.htm>