[Webkit-unassigned] [Bug 203359] export-w3c-test-changes should add the "webkit-exports" label in GitHub

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203359

--- Comment #4 from Pablo Saavedra <psaavedra at igalia.com> ---
(In reply to Pablo Saavedra from comment #3)
> the script uses `add_label` from webkitpy/w3c/wpt_github.py to set the label
> for the PR:
> 
> 
> ```
>     def add_label(self, number, label):
>         """Adds a label to a GitHub issue (or PR).
> 
>         API doc:
> https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue
>         """
>         path = '/repos/%s/%s/issues/%d/labels' % (
>             WPT_GH_ORG,
>             WPT_GH_REPO_NAME,
>             number
>         )
>         body = [label]
>         response = self.request(path, method='POST', body=body)
> ```
> 
> 
> the function is sending the labels as a list of one single string but note
> that this Github API is expecting a JSON document
> (https://developer.github.com/v3/issues/labels/#example-2):
> 
> {
>   "labels": ["bug", "enhancement"]
> }

This must be confirmed. Maybe the other one is working as well despite not being part the documentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191104/c9adb555/attachment.htm>