[Webkit-unassigned] [Bug 203642] covscan: Incorrect check in RenderBox::hasOverrideContainingBlockContentHeight

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203642

--- Comment #5 from Eike Rathke <erack at redhat.com> ---
If the test now fails due to this change it means that cb->style().isHorizontalWritingMode() is false there. Really intended? i.e. does the tested code actually set that to false on purpose?

All other places that ask isHorizontalWritingMode() already use X/width for width if true, and Y/height if false (and vice versa for height), not doing it here looks unexpected to me. And then no check on isHorizontalWritingMode() at all would be needed.

The only place calling RenderBox::hasOverrideContainingBlockContentHeight() seems to be RenderBoxModelObject::relativePositionOffset()

I'm off here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191101/c3e667f0/attachment.htm>