[Webkit-unassigned] [Bug 197894] Inserting a newline in contenteditable causes two characters to be added instead of one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 15:10:32 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197894

--- Comment #36 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Wenson Hsieh from comment #34)
> Comment on attachment 370964 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370964&action=review
> 
> Seems reasonable, though I'm not familiar with the accessibility part of
> this patch.
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1624
> > +        Node* node = this->node();
> 
> Nit - auto

Done.

> > LayoutTests/accessibility/ios-simulator/set-selected-text-range-after-newline.html:35
> > +        shouldBecomeEqual("text.selectedTextRange", "'{5, 0}'", function() {
> > +                          text.replaceTextInRange("\n", 5, 0);
> > +
> > +                          var t = text.stringForRange(0, 11);
> > +                          t = t.replace(/(?:\r\n|\r|\n)/g, '[newline]');
> > +                          debug("There must be only one [newline] between hello and world: " + t);
> > +
> > +                          text.setSelectedTextRange(6, 0);
> > +                          shouldBecomeEqual("text.selectedTextRange", "'{6, 0}'", function() {
> > +                                            var t = text.stringForRange(6, 5);
> > +                                            t = t.replace(/(?:\r\n|\r|\n)/g, '[newline]');
> > +                                            debug("The text after the newline should be world: " + t);
> > +
> > +                                            finishJSTest();
> > +                                            });
> > +                          });
> 
> Nit - indentation still looks off.


Fixed now for iOS test. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190530/58bb14d4/attachment.html>


More information about the webkit-unassigned mailing list