[Webkit-unassigned] [Bug 197894] Inserting a newline in contenteditable causes two characters to be added instead of one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 12:20:32 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197894

--- Comment #33 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Wenson Hsieh from comment #31)
> Comment on attachment 370575 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370575&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +        Reviewed by NOBODY (OOPS!).
> 
> You should add a ChangeLog entry here describing the bug and the fix.
>
Done.

> > Source/WebCore/editing/Editing.cpp:1127
> > +        RefPtr<Range> r = it.range();
> 
> Nits:
> - You can use auto here instead of RefPtr<Range>.
> - We also generally avoid single character variable names like `r`, in favor
> of `range`.
>
Done.

> > LayoutTests/accessibility/set-selected-text-range-after-newline.html:21
> > +                          text.replaceTextInRange("\n", 5, 0);
> 
> Nit - indentation looks off here. We don't align to the start of the
> brace/parenthesis like this in WebKit.

Fixed. Was using Xcode default indentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190530/c31def08/attachment.html>


More information about the webkit-unassigned mailing list