[Webkit-unassigned] [Bug 198367] REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198367

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 370932 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370932&action=review
> 
> Nice catch!

Thanks.

> > Source/WebKit/ChangeLog:9
> > +        RenderingUpdateScheduler. The threaded compositor display refresh monitor is destroyed without completing the
> 
> Mind replacing "threaded compositor display refresh monitor" by
> ThreadedDisplayRefreshMonitor ? The former is a bit difficult to read.

Sure.

> > Source/WebKit/ChangeLog:11
> > +        need to ensure we complete the frame request before destrying the display refresh monitor to leave the
> 
> Nit: destrying -> destroying

Oops

> > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:94
> > +        DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);
> 
> Looks like DisplayReferehMonitor already protects client notifications so it
> should be safe to call this even when the object is about to be destroyed.
> Could you confirm that?

That's right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190530/895530a5/attachment.html>