[Webkit-unassigned] [Bug 198349] New: check-webkit-style reports false-positive build/include_order warning in WTF C++ source files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 13:23:21 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=198349

            Bug ID: 198349
           Summary: check-webkit-style reports false-positive
                    build/include_order warning in WTF C++ source files
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org

check-webkit-style reports false-positive build/include_order warning in WTF C++ source files.

For example, see Bug 198346 Comment #3:  <https://bugs.webkit.org/show_bug.cgi?id=198346#c3>

ERROR: Source/WTF/wtf/CrossThreadTaskHandler.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]

For this source in Source/WTF/wtf/CrossThreadTaskHandler.cpp:

    #include "config.h"
    #include <wtf/CrossThreadTaskHandler.h>

    #include <wtf/AutodrainedPool.h>

For whatever reason, most C++ source files in WTF use <wtf/Header.h> instead of "Header.h".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190529/9399ce21/attachment.html>


More information about the webkit-unassigned mailing list