[Webkit-unassigned] [Bug 197834] [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197834

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369955|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 369955
  --> https://bugs.webkit.org/attachment.cgi?id=369955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369955&action=review

> Source/WebCore/ChangeLog:8
> +        The buffering state and the m_downloadFinished boolean aren't supported in MSE case.

in the MSE case

> Source/WebCore/ChangeLog:10
> +        else the MediaPlayer would send a "canplay" event instead of "canplaythrough".

else -> or else, instead of a

> LayoutTests/ChangeLog:8
> +        Add a new test that check if the MediaElement receive the "canplaythrough"

checks, receives

> LayoutTests/media/media-source/media-source-canplaythrough-event.html:18
> +        waitForEventOn(video, 'canplaythrough', oncanplaythrough, false, true);

I think we can remove oncanplaythrough if we use:

waitForEventAndEnd('canplaythrough', null);

> LayoutTests/media/media-source/media-source-canplaythrough-event.html:25
> +    function oncanplaythrough() {
> +        passTest("Receive canplaythrough event");
> +    }

I think we could remove this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190528/1a11ed0c/attachment.html>