[Webkit-unassigned] [Bug 197971] GLContextEGL should check the supported EGL version at compile time
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 27 16:12:43 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=197971
--- Comment #15 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 370343
--> https://bugs.webkit.org/attachment.cgi?id=370343
Use a generic macro for EGL context version
View in context: https://bugs.webkit.org/attachment.cgi?id=370343&action=review
I think this is looking pretty good for landing now. Could a reviewer
please take a look? (Thanks!)
> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:407
> + || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) {
I quite like unifying the two if-branches into a single one, good thinking! Probably
we still want to do the #ifndef-#define dance for the macros, because EGL 1.5 headers
might provide EGL_CONTEXT_MAJOR_VERSION, but not EGL_CONTEXT_MAJOR_VERSION_KHR as an
extension — though it is very likely that the _KHR symbols are provided also on EGL 1.5
headers, so it is probably fine to merge this patch as-is, and add the #ifdef-#define
bits if needed in the future... What do reviewers think about this?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190527/fe82ec58/attachment.html>
More information about the webkit-unassigned
mailing list