[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197873

--- Comment #33 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #24)
> Comment on attachment 370479 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370479&action=review
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImpl.h:88
> > +    std::unique_ptr<WriteBuffer> m_writeBuffer { nullptr };
> 
> Remove "{ nullptr }". unique_ptr has ctor.

Fixed.

> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:83
> > +            return 0;
> 
> return WTF::nullopt;

Returning WTF::nullopt means some error occurs, our situation doesn't seem to be an error.
Do we have to return WTF::nullopt ?


> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:143
> > +            auto bytesSent = socket.send(m_writeBuffer->firstBlockData(), std::min(m_writeBuffer->firstBlockSize(), kWriteBufferSize));
> 
> I think it is nonsense to limit size by kWriteBufferSize here.

Removed limiting value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190525/fbdcb5f3/attachment.html>