[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197873

--- Comment #31 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #22)
> Comment on attachment 370479 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370479&action=review
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImpl.h:86
> > +    Lock m_writeMutex;
> 
> You shouldn't have m_writeMutex. Instead, you should have bool
> m_hasPendingWriteData.
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:-83
> > -        return 0;
> 
> In the original implementation, platformSendInternal keeps returning 0 until
> the previous chunk will be sent completely.
> I think this behavior is enough.
> But, it should return WTF::nullopt.
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:153
> >                      sendPendingData();
> 
> Do "m_hasPendingWriteData = false" here.

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190525/a92c3380/attachment.html>