[Webkit-unassigned] [Bug 198144] webkitpy: Switch run-webkit-tests to tailspin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198144

--- Comment #7 from David Xiong <w_xiong at apple.com> ---
Comment on attachment 370473
  --> https://bugs.webkit.org/attachment.cgi?id=370473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370473&action=review

>> Tools/Scripts/webkitpy/port/darwin.py:213
>> +    def temp_tailspin_file_path(host, name, pid, directory):
> 
> The original intention of these functions was to handle the fact that we would be calling it with multiple hosts. In the temp_tailspin_file_path case, though, I think we can get away with just doing something like this:
> 
> temp_tailspin_file = host.filesystem.join(directory, "{0}-{1}-tailspin-temp.txt".format(name, pid))
> 
> in sample_process.

Good point, I'll also get rid of spindump_file_path as I don't think it's being used anywhere anymore

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190524/3890475c/attachment-0001.html>