[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197873

--- Comment #24 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 370479
  --> https://bugs.webkit.org/attachment.cgi?id=370479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370479&action=review

> Source/WebCore/platform/network/curl/SocketStreamHandleImpl.h:88
> +    std::unique_ptr<WriteBuffer> m_writeBuffer { nullptr };

Remove "{ nullptr }". unique_ptr has ctor.

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:83
> +            return 0;

return WTF::nullopt;

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:143
> +            auto bytesSent = socket.send(m_writeBuffer->firstBlockData(), std::min(m_writeBuffer->firstBlockSize(), kWriteBufferSize));

I think it is nonsense to limit size by kWriteBufferSize here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190523/3de64d52/attachment-0001.html>