[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 22 20:57:45 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=197873
--- Comment #22 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 370479
--> https://bugs.webkit.org/attachment.cgi?id=370479
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370479&action=review
> Source/WebCore/platform/network/curl/SocketStreamHandleImpl.h:86
> + Lock m_writeMutex;
You shouldn't have m_writeMutex. Instead, you should have bool m_hasPendingWriteData.
> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:-83
> - return 0;
In the original implementation, platformSendInternal keeps returning 0 until the previous chunk will be sent completely.
I think this behavior is enough.
But, it should return WTF::nullopt.
> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:153
> sendPendingData();
Do "m_hasPendingWriteData = false" here.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190523/d43e468f/attachment.html>
More information about the webkit-unassigned
mailing list