[Webkit-unassigned] [Bug 198144] webkitpy: Switch run-webkit-tests to tailspin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198144

--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 370468
  --> https://bugs.webkit.org/attachment.cgi?id=370468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370468&action=review

> Tools/ChangeLog:9
> +        Changes run-webkit-tests to run tailspin on test time out, and

Instead of what?

> Tools/ChangeLog:12
> +        * Scripts/webkitpy/port/darwin.py:

Tell us what changed in these functions, unless the function name makes it obvious (like DarwinPort.tailspin_file_path)

> Tools/Scripts/webkitpy/port/darwin.py:179
> +                    DarwinPort.temp_tailspin_file_path(host, name, pid, str(tempdir)),

Will spindump let you make the input and output file the same file? That would make this code simpler (and testing easier)

> Tools/Scripts/webkitpy/port/darwin.py:183
> +                host.executive.run_command(symbolicate_command)

We probably don't need to name the list here, the only reason we did that with sudo was because we maybe had to add sudo.

> Tools/Scripts/webkitpy/port/darwin.py:214
> +    def temp_tailspin_file_path(host, name, pid, directory):

We won't need this function if we make spindump use the same file during symbolication.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190523/bbf29057/attachment.html>