[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197873

--- Comment #15 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Daniel Bates from comment #8)
> Comment on attachment 369828 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369828&action=review
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:51
> > +    : SocketStreamHandle(url.isolatedCopy(), client)
> 
> I know next to nothing about this code, but this change looks unnecessary.
> Isolate copy is only necessary when threads are involved. If threads are
> involved they aren't involved in this function as far as I can tell. They
> must be in SocketStreamHandle. So, this change should go there. Get this
> change as close to the thread creation code as possible. All of this is
> premised on threads. No threads, no need to isolate copy.

Thank you for your comment.
Fxed to use isolatedCopy of m_url appropriately.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190522/b0c019ec/attachment.html>