[Webkit-unassigned] [Bug 197973] 'analysis-task-configurator-pane' does not update when switch from one analysis task to another

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197973

--- Comment #5 from dewei_zhu at apple.com ---
Comment on attachment 370328
  --> https://bugs.webkit.org/attachment.cgi?id=370328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370328&action=review

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:79
> +    },{

Nit, '{' should be a separate line. Ditto for belows.

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:174
> +    }

Nit: Add ';' to the end.

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:179
> +        repositoryGroups:[]

Nit, one space after ':'

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:229
> +        }).forEach((buildRequest) => {

For one-liner, we can just do, (buildRequest) => testGroup1.addBuildRequest(buildRequest)

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:245
> +        });

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190521/eb10a36f/attachment-0001.html>