[Webkit-unassigned] [Bug 197973] 'analysis-task-configurator-pane' does not update when switch from one analysis task to another

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197973

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370095|review?                     |review-
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 370095
  --> https://bugs.webkit.org/attachment.cgi?id=370095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370095&action=review

> Websites/perf.webkit.org/ChangeLog:13
> +        * public/v3/components/custom-analysis-task-configurator.js:
> +        (CustomAnalysisTaskConfigurator.prototype.setCommitSets):
> +        * public/v3/pages/analysis-task-page.js:
> +        (AnalysisTaskConfiguratorPane.prototype.setTestGroups):

Please explain what you're fixing.
r- due to the lack of explanation about the root cause.

> Websites/perf.webkit.org/ChangeLog:1439
> -        (Statistics.findRangesForChangeDetectionsWithWelchsTTest): The argument `segmentations`, every 2 items in the list defines 
> +        (Statistics.findRangesForChangeDetectionsWithWelchsTTest): The argument `segmentations`, every 2 items in the list defines

Please don't fix past change log entires.

> Websites/perf.webkit.org/ChangeLog:1922
> -        (ReportProcessor::resolve_build_id): 
> +        (ReportProcessor::resolve_build_id):

Ditto.

> Websites/perf.webkit.org/browser-tests/analysis-task-page-tests.js:8
> +    const fakeTestGroupData1 = {

We don't usually prefix these data entires by fake or mock
since that's pretty self-evident from the fact this is test data.

> Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:95
> -        const comparisonRepositoryGroup = triggerable.repositoryGroups().find((repositoryGroup) => repositoryGroup.accepts(baselineCommitSet));
> +        const comparisonRepositoryGroup = triggerable.repositoryGroups().find((repositoryGroup) => repositoryGroup.accepts(comparisonCommitSet));

Why are we making this change?

> Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:223
> -        if (!form.hasCommitSets() && currentGroup)
> +        if (currentGroup)

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190520/07e36555/attachment.html>