[Webkit-unassigned] [Bug 198033] ErrorObjectView display black link in dark mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 16:22:09 PDT 2019


--- Comment #15 from Zhifei Fang <zhifei_fang at apple.com> ---
(In reply to Devin Rousso from comment #13)
> Comment on attachment 370265 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370265&action=review
> r-
> > Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css:57
> > +    .error-object-link-container {
> This doesn't fix the issue for me, as there's a `.console-message
> .go-to-arrow` that has a higher specificity.  Please match the styling of
> `.call-frame .subtitle`, `.call-frame .separator`, and `.call-frame
> .subtitle .source-link` so we have the same coloring everywhere.
> I also agree with @Nikita in that we should always use the CSS variable in
> light and dark mode.

Thanks, I am not 100% sure if my fix works, trying to make inspector can inspect another inspector to verify it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190520/1e951b85/attachment.html>

More information about the webkit-unassigned mailing list