[Webkit-unassigned] [Bug 198033] ErrorObjectView display black link in dark mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 13:53:35 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=198033

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #370265|review?                     |review-
              Flags|                            |

--- Comment #13 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370265
  --> https://bugs.webkit.org/attachment.cgi?id=370265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370265&action=review

r-

> Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css:57
> +    .error-object-link-container {

This doesn't fix the issue for me, as there's a `.console-message .go-to-arrow` that has a higher specificity.  Please match the styling of `.call-frame .subtitle`, `.call-frame .separator`, and `.call-frame .subtitle .source-link` so we have the same coloring everywhere.

I also agree with @Nikita in that we should always use the CSS variable in light and dark mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190520/5088ee72/attachment-0001.html>


More information about the webkit-unassigned mailing list