[Webkit-unassigned] [Bug 198037] [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 06:19:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=198037

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #370249|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370249
  --> https://bugs.webkit.org/attachment.cgi?id=370249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370249&action=review

> Source/JavaScriptCore/API/glib/JSCClass.cpp:346
> -            static_cast<GParamFlags>(WEBKIT_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)));
> +            static_cast<GParamFlags>(WEBKIT_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY)));

Nothing like a good API break to make a change exciting.

I think we can get away with this, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190520/4c972bfe/attachment.html>


More information about the webkit-unassigned mailing list