[Webkit-unassigned] [Bug 197971] GLContextEGL should check the supported EGL version at compile time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 18 08:04:17 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #370161|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370161
  --> https://bugs.webkit.org/attachment.cgi?id=370161
Fix to check the EGL version at compile time

View in context: https://bugs.webkit.org/attachment.cgi?id=370161&action=review

OK this looks better, thanks!

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:419
>          } else if (platformDisplay.eglCheckVersion(1, 4)) {
> +#else
> +        if (platformDisplay.eglCheckVersion(1, 4)) {
> +#endif

How about:

} else
    if (platformDisplay.eglCheckVersion(1, 4)) {

That way we don't need to repeat the condition at all.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190518/9e332d74/attachment.html>

More information about the webkit-unassigned mailing list