[Webkit-unassigned] [Bug 197955] Web Inspector: Dark Mode: Fix colors in network table waterfall container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 17 13:33:56 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197955

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370139|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370139
  --> https://bugs.webkit.org/attachment.cgi?id=370139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370139&action=review

r=me, nice fix!

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211
> +    background-color: var(--network-waterfall-fullscreen-area-color);

There's no reason to make a variable if it's only really used once (or even twice).  Please just inline it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190517/a954ca30/attachment.html>


More information about the webkit-unassigned mailing list