[Webkit-unassigned] [Bug 197955] Web Inspector: Dark Mode: Fix colors in network table waterfall container

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197955

--- Comment #6 from Jamal Nasser <jamaln at mail.com> ---
(In reply to Devin Rousso from comment #3)
> Comment on attachment 370060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370060&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211
> > +    background-color: var(--dashboard-background-color);
> 
> We probably don't want to reuse a variable like this, since the fullscreen
> event area has nothing to do with the dashboard.  Also, FWIW I think we
> might want to make it slightly lighter, almost halfway between what you have
> now `hsl(0, 0%, 36%)` and what was there before `hsla(0, 0%, 75%, 0.75)`. 
> Maybe a regular `grey` or a `hsla(0, 0%, 50%)`?

50% is a little too bright in my opinion. This is what 40% looks like: https://i.imgur.com/d8Q1V8A.png

I think that fits better than 50%:
https://i.imgur.com/Rz0RRuV.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190517/76426edf/attachment.html>