[Webkit-unassigned] [Bug 197971] GLContextEGL should check the supported EGL version at compile time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197971

--- Comment #5 from Mads <madhurkiran.h at gmail.com> ---
Sorry, but there is the ifdef in the patch, I think you missed that.

--- a/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
+++ b/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
@@ -372,7 +372,7 @@ EGLContext GLContextEGL::createContextForEGLVersion(PlatformDisplay& platformDis
         // we'll use whatever is available. In order to request a concrete version of OpenGL we need EGL version
         // 1.5 or EGL version 1.4 with the extension EGL_KHR_create_context.
         EGLContext context = EGL_NO_CONTEXT;
-
+#ifdef EGL_VERSION_1_5
         if (platformDisplay.eglCheckVersion(1, 5)) {
             contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION;
             contextAttributes[1] = 3;
@@ -384,7 +384,11 @@ EGLContext GLContextEGL::createContextForEGLVersion(PlatformDisplay& platformDis

             // Try to create a context with this configuration.
             context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes);
-        } else if (platformDisplay.eglCheckVersion(1, 4)) {
+        } else if
+#else
+       if
+#endif
+               (platformDisplay.eglCheckVersion(1, 4)) {
             const char* extensions = eglQueryString(platformDisplay.eglDisplay(), EGL_EXTENSIONS);
             if (GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context")) {
                 contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR;
-- 
2.7.4

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190517/84e0c040/attachment.html>