[Webkit-unassigned] [Bug 197413] [WPE] Add initial accessibility support using ATK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197413

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #7)
> I have no idea what this is for, I just copy-paste when I have to do CMake
> stuff. So, tell me what I should here, just remove it?

Yeah, remove it.

> > > Source/WebKit/UIProcess/API/wpe/WPEView.h:63
> > > +    ~View();
> > 
> > Should we make this class noncopyable now? Probably?
> 
> Why now?

Rule of three. What behavior would be sensible if it was copyable?

Zan's right, of course, in that it's already not copyable. I usually like to clarify this by deleting the copy constructor and copy assignment operator, but whatever, it's not a big deal and we're far afield of the change under consideration now.

> > > Tools/wpe/backends/WebKitAccessibleApplication.cpp:88
> > > +    g_type_class_add_private(klass, sizeof(WebKitAccessibleApplicationPrivate));
> > 
> > You know this is deprecated? Modern GObjects should use G_ADD_PRIVATE() in
> > the G_DEFINE_TYPE() up above, then use
> > webkit_accessible_application_get_instance_private() to get the priv struct.
> > Anyway, your choice.
> 
> Yes, I know it, but I think we still depend on a previous version.

I doubt it, G_ADD_PRIVATE() has been around since 2.38.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190517/1782dcd0/attachment.html>