[Webkit-unassigned] [Bug 197955] Web Inspector: Dark Mode: Fix colors in network table waterfall container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 14:11:58 PDT 2019


Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |drousso at apple.com

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370060
  --> https://bugs.webkit.org/attachment.cgi?id=370060

View in context: https://bugs.webkit.org/attachment.cgi?id=370060&action=review

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211
> +    background-color: var(--dashboard-background-color);

We probably don't want to reuse a variable like this, since the fullscreen event area has nothing to do with the dashboard.  Also, FWIW I think we might want to make it slightly lighter, almost halfway between what you have now `hsl(0, 0%, 36%)` and what was there before `hsla(0, 0%, 75%, 0.75)`.  Maybe a regular `grey` or a `hsla(0, 0%, 50%)`?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190516/159b8d87/attachment.html>

More information about the webkit-unassigned mailing list