[Webkit-unassigned] [Bug 197894] Inserting a newline in contenteditable causes two characters to be added instead of one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197894

--- Comment #10 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to chris fleizach from comment #4)
> Comment on attachment 369892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369892&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:-2746
> > -                return [NSValue valueWithRange:NSMakeRange(0, 0)];
> 
> what issue was this one causing?

It is harmless but unnecessary to check for isNull because it will return the same thing, the range is null if and only if both location and length are 0 so this return and the one below will be the same. Thought I should clean up since looking at this code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190516/734753df/attachment.html>