[Webkit-unassigned] [Bug 197836] Event region computation should respect transforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 10:27:40 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197836

--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
> Is it acceptable to just use enclosing rects?

Event region is used to synchronously determine on UI process side whether swipes should scroll or not. In this use approximation is often unnoticeable and definitely better than getting it completely wrong.

If needed this can be improved later, either by approximating with more rects or by using different data structures (bitmap or multiple Regions with attached transforms).

> Not sure why we have this since EventRegionContext also has a public
> constructor. And it’s only used in one place. I think we could do without
> it. Not sure, it does seem a little more elegant than invoking a constructor.

I like construction function like this because then the client site does not need to spell out uninteresting types:

auto eventRegionContext = eventRegion.makeContext();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190514/8f973520/attachment.html>


More information about the webkit-unassigned mailing list