[Webkit-unassigned] [Bug 197836] Event region computation should respect transforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 09:03:47 PDT 2019


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com
 Attachment #369836|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 369836
  --> https://bugs.webkit.org/attachment.cgi?id=369836

View in context: https://bugs.webkit.org/attachment.cgi?id=369836&action=review

> Source/WebCore/ChangeLog:12
> +        Add support for transforming regions. Non-rectlinear results use enclosing rects.

Is it acceptable to just use enclosing rects?

> Source/WebCore/rendering/EventRegion.h:41
> +    EventRegionContext(EventRegion&);

We want "explicit" here since we wouldn’t want this to be done as a conversion.

> Source/WebCore/rendering/EventRegion.h:58
> +    EventRegionContext makeContext() { return { *this }; }

Not sure why we have this since EventRegionContext also has a public constructor. And it’s only used in one place. I think we could do without it. Not sure, it does seem a little more elegant than invoking a constructor.

> Source/WebCore/rendering/RenderLayer.cpp:4603
> +    auto oldTransfrom = context.getCTM();

Spelling error here: "transfrom".

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190514/66cea98a/attachment.html>

More information about the webkit-unassigned mailing list