[Webkit-unassigned] [Bug 197873] [CURL] Fix crashing SocketStreamHandle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197873

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369828
  --> https://bugs.webkit.org/attachment.cgi?id=369828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369828&action=review

> Source/WebCore/ChangeLog:8
> +        When NetworkSocketStream is destructed SocketStreamHandleImple::platformClose is called wrongly times.

I don't understand this sentence. platformClose is called multiple times?

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:106
> +    m_state = Closed;

I don't understand why you need to set m_state here. m_state is set in SocketStreamHandle::disconnect.
https://github.com/WebKit/webkit/blob/e10a60ba94615a5c607799986b3ed42a88591e0b/Source/WebCore/platform/network/SocketStreamHandle.cpp#L81

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:-146
> -                m_writeBuffer = nullptr;

Why do you want not to release the buffer here? It successfully sent the whole buffer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190514/3f419fd2/attachment.html>