[Webkit-unassigned] [Bug 185764] [WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 9 05:40:04 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=185764
--- Comment #15 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 369485
--> https://bugs.webkit.org/attachment.cgi?id=369485
Patch to add set_device_scale_factor implementation declared by libwpe
View in context: https://bugs.webkit.org/attachment.cgi?id=369485&action=review
The patch needs a small change before we can land it; other that
that, functionality looks good to me. Thanks Ryan!
> Source/WebKit/ChangeLog:9
> + Wayland and calls setIntrinsicDeviceScaleFactor() for the current View.Page object. The
The scale factor can be from Wayland in the case where one us using a
WPE backend which uses Wayland… or it can from something else when not
using Wayland 🤔
What do you think of rephrasing this as “…scale factor from configured
through wpe_view_backend_dispatch_set_device_scale_factor() and calls…”?
> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:111
> nullptr
You will have to change this because now we also have a “get_accesible” function.
The current definition (as of commit f15b1d1) has the following definition:
struct wpe_view_backend_client {
void (*set_size)(void*, uint32_t, uint32_t);
void (*frame_displayed)(void*);
void (*activity_state_changed)(void*, uint32_t);
void* (*get_accessible)(void*);
void (*set_device_scale_factor)(void*, float);
void (*_wpe_reserved0)(void);
};
So we will need one of the “nullptr” items moved up before the lambda
which implementes the ”set_device_scale” callback.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190509/f070b63b/attachment.html>
More information about the webkit-unassigned
mailing list