[Webkit-unassigned] [Bug 197695] fast/hidpi/video-controls-in-hidpi.html sometimes asserts in WK1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 23:07:29 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197695

--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
The fix is something like:

index 15479365f2edf9776a01e4f4e70c792921824975..8532ac6c3acb2df5eb75a5d6b43981d2cc5c4eaa 100644
--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
@@ -1022,8 +1022,13 @@ void RenderLayerCompositor::computeCompositingRequirements(RenderLayer* ancestor
         addToOverlapMap(overlapMap, layer, layerExtent);

 #if ENABLE(CSS_COMPOSITING)
+    bool isolatedCompositedBlending = layer.isolatesCompositedBlending();
     layer.setHasNotIsolatedCompositedBlendingDescendants(childState.hasNotIsolatedCompositedBlendingDescendants);
     ASSERT(!layer.hasNotIsolatedCompositedBlendingDescendants() || layer.hasNotIsolatedBlendingDescendants());
+    if (layer.isolatesCompositedBlending() != isolatedCompositedBlending) {
+        // isolatedCompositedBlending affects the answer to clippedByAncestor().
+        layer.setChildrenNeedCompositingGeometryUpdate();
+    }
 #endif
     // Now check for reasons to become composited that depend on the state of descendant layers.
     RenderLayer::IndirectCompositingReason indirectCompositingReason;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190509/2cffc9b2/attachment.html>


More information about the webkit-unassigned mailing list