[Webkit-unassigned] [Bug 197430] [css-text] break-all shouldn't allow breaking opportunities before a slash character

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 13:31:26 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197430

--- Comment #9 from Myles C. Maxfield <mmaxfield at apple.com> ---
Looks like Chrome has the same table that we do, except for a difference in one line:

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/BreakLines.cpp#L53

https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/platform/text/text_break_iterator.cc#L124

The line that's different is:

{ B(1, 1, 1, 1, 1, 1, 1, 1), B(1, 1, 1, 0, 1, 0, 1, 0), 0, B(0, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 1, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().

vs

{ B(0, 1, 1, 0, 1, 1, 1, 1), B(0, 1, 1, 0, 1, 0, 0, 0), 0, B(0, 0, 0, 1, 1, 1, 0, 1), F, F, F, B(1, 1, 1, 1, 0, 1, 1, 1), F, F, F, B(1, 1, 1, 1, 0, 1, 1, 1) }, // - Note: breaking before '0'-'9' is handled hard-coded in shouldBreakAfter().

It looks like the Chrome line was modified in:

https://codereview.chromium.org/2490153002
https://codereview.chromium.org/1370203005

and the WebKit line was modified in:

https://bugs.webkit.org/show_bug.cgi?id=185899

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190508/091ce821/attachment.html>


More information about the webkit-unassigned mailing list