[Webkit-unassigned] [Bug 197432] [WinCairo] Implement and enable RemoteInspector Server.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 11:19:19 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197432

--- Comment #2 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
(In reply to Basuke Suzuki from comment #1)
> > > Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:231
> > > +    // fcntl(socket, F_SETFD, FD_CLOEXEC);
> > > +    // int flags = fcntl(socket, F_GETFL, 0);
> > > +    // fcntl(socket, F_SETFL, flags | O_NONBLOCK);
> > 
> > Can these comments be deleted?
> 
> Can I add FIXME comment for future improvement?

I confirmed these are not required on Windows. I'll remove them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190502/e0fb392b/attachment.html>


More information about the webkit-unassigned mailing list