[Webkit-unassigned] [Bug 178867] ASSERTION FAILED: match() == PseudoClass in WebCore::CSSSelector::pseudoClassType

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 09:46:33 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=178867

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dbates at webkit.org
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=131295

--- Comment #1 from Daniel Bates <dbates at webkit.org> ---
Just hit this today (05/02) when I clicked Login on Wordpress.com on iPad. From debugging, in frame WebCore::CSSSelector::pseudoClassType() const:


(lldb) p match()
(WebCore::CSSSelector::Match) $0 = Class
(lldb) p m_pseudoType
(unsigned int) $1 = 0

m_pseudoType is type PseudoClassType, PseudoClassUnknown = 0.

The assert was added in the patch for bug #131295.

On first glance, I think the assert is *wrong*. On second glance, looking at isPseudoClassValidAfterPseudoElement(), I am even more convinced the assert is *wrong* because isPseudoClassValidAfterPseudoElement() and the functions it calls are more than capable of handling the case where pseudoClassType() returns PseudoClassUnknown. Third glance needed to read through the patch for bug #131295 and I don't have time at the moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190502/102ceaf2/attachment-0001.html>


More information about the webkit-unassigned mailing list