[Webkit-unassigned] [Bug 188986] [CMake] Add support for LTO builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188986

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
(In reply to Christopher Reid from comment #4)
> > I ran into some LTO issues when enabling it for Xcode, I want to make sure
> > they are accounted for in your patch, too.
> > 
> > It's been a couple of years since I tried compiling JavaScriptCore with LTO,
> > but when I did, I ran into a runtime crash. I don't understand the details,
> > but the explanation I was given had something to do with JSC assuming there
> > were implicit compiler fences that were abolished when LTO was applied. So
> > if you're enabling LTO for JSC, be sure to run a full suite of tests. (If
> > they pass, then I should probably try building JSC again under LTO to see if
> > the bug I hit has gone away.)
> We're focused on enabling LTO without JIT on x86_64. I'm not sure if that
> fence issue was specific to JIT.
> I also just tested jsc tests with jit enabled and haven't seen any new
> failures when turning on LTO on both clang-7 and clang-8 in my ubuntu
> environment.

I don't think this issue only happens in JIT enabled environment.
I think the typical issue is like this. http://trac.webkit.org/changeset/196259/webkit

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190502/6abdf1da/attachment-0001.html>